Introduce fromImage field in jib builder interface.
#4873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsquared94
requested review from
chanseokoh,
loosebazooka and
a team
as code owners
Codecov Report
@@ Coverage Diff @@
## master #4873 +/- ##
==========================================
+ Coverage 71.86% 72.08% +0.21%
==========================================
Files 356 358 +2
Lines 12218 12368 +150
==========================================
+ Hits 8780 8915 +135
- Misses 2786 2797 +11
- Partials 652 656 +4
Continue to review full report at Codecov.
|
gsquared94
force-pushed
the
fix-4713-jib-interface
branch
from
6f0193a
to
391629e
Compare
briandealwis
approved these changes
Oct 14, 2020
Co-authored-by: Brian de Alwis <bsd@acm.org>
gsquared94
changed the title
baseImage field in jib builder interface.fromImage field in jib builder interface.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #4713
This PR introduces
fromImageas a property in thejibbuilder to override the configured base image.It's required in the implementation of supporting artifact dependencies